1.adjust the ready function #246
Conversation
|
Hi, what's the issue you want to solve? Please add a proper description. |
|
I want to use hemera like the fastify framework, but in hemera, I can only use the registration of ready once, but not multiple times, so I can't nest the ready registration function internally when writing the hemera plugin. |
|
Could you make an example? |
|
` hemera.register(hemeraPlugin((h,opts,done)=>{ hemera.ready(()=>{ ` |
| this._transport.driver.on('connect', () => { | ||
| this.log.info('Connected!') | ||
|
|
||
| this._isReadyWaits.forEach((readyCall)=>{ |
There was a problem hiding this comment.
I think this doesn't work because you call _registerEvents in the constructor. At that time no user has registered a ready callback handler.
| this._transport.driver.on('disconnect', () => { | ||
| this.log.warn('NATS disconnected!') | ||
| }) | ||
| // if (this._isReady) { |
There was a problem hiding this comment.
Remove comments if you are done.
| @@ -18,7 +18,9 @@ describe('Hemera', function() { | |||
| const hemera = new Hemera(nats) | |||
| hemera.ready(() => { | |||
| try { | |||
| hemera.ready() | |||
| hemera.ready(()=>{ | |||
| @@ -64,6 +64,7 @@ class Hemera { | |||
|
|
|||
| this._root = this | |||
| this._isReady = false | |||
| this._isReadyWaits = [] | |||
There was a problem hiding this comment.
is expresses a boolean value this is a list.
|
I have developed my own beanify microservice framework to replace Hemera |
Adjust the ready function to allow multiple registration callback functions