Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staticman fails to create pull request when making comments #6218

Closed
hendrixjoseph opened this issue Jul 17, 2019 · 0 comments
Closed

Staticman fails to create pull request when making comments #6218

hendrixjoseph opened this issue Jul 17, 2019 · 0 comments

Comments

@hendrixjoseph
Copy link
Owner

Staticman fails to create a pull request when a comment is submitted. A new branch with the comment file is created, however.

I've upgraded from Staticman v2 to Staticman v3 (as a github app) according to Staticman issue #243. This issue happened with both v2 and v3 - see issue #6215.

Theories:

  • Staticman no longer has pull request permission due to the large number of spam PRs
  • Apps in general no longer have pull request permission due to the large number of spam PRs (verified as false with issue [ImgBot] Optimize images #6217 )
  • Something else I'm doing wrong
  • Something else wrong with Staticman

Staticman JSON Response when submitting a comment:

{
	"success": false,
	"rawError": {
		"name": "HttpError",
		"status": 500,
		"headers": {},
		"request": {
			"method": "PUT",
			"url": "https://api.github.com/repos/hendrixjoseph/hendrixjoseph.github.io/contents/_data/comments/rethinking-the-flag-of-huber-heights-ohio/entry1563390336115.yml",
			"headers": {
				"accept": "application/vnd.github.v3+json",
				"user-agent": "Staticman agent octokit.js/16.8.0 Node.js/11.12.0 (Linux 4.4; x64)",
				"authorization": "token v1.328aa9dc55532b7b693cfe34f8de854c3ffb78c1",
				"content-type": "application/json; charset=utf-8"
			},
			"body": "{\"message\":\"Add Staticman comment from JoeHx at https://hendrixjoseph.github.io/\",\"content\":\"X2lkOiBkYWY3NjFlMC1hOGM1LTExZTktODIzNi00ZjMzZTUzNzI4ZjgKbXNnOiB0dHR0dHR0dGVzdApuYW1lOiBKb2VIeAplbWFpbDogZTU5MWYzYWE3YzhjYmQ3ZGQ5ZTMzODk5NTg5NDllZDMKdXJsOiAnaHR0cHM6Ly9oZW5kcml4am9zZXBoLmdpdGh1Yi5pby8nCmRhdGU6IDE1NjMzOTAzMzYK\",\"branch\":\"staticman_daf761e0-a8c5-11e9-8236-4f33e53728f8\"}",
			"request": {
				"timeout": 5000,
				"validate": {
					"author": {
						"type": "object"
					},
					"author.email": {
						"required": true,
						"type": "string"
					},
					"author.name": {
						"required": true,
						"type": "string"
					},
					"branch": {
						"type": "string"
					},
					"committer": {
						"type": "object"
					},
					"committer.email": {
						"required": true,
						"type": "string"
					},
					"committer.name": {
						"required": true,
						"type": "string"
					},
					"content": {
						"required": true,
						"type": "string"
					},
					"message": {
						"required": true,
						"type": "string"
					},
					"owner": {
						"required": true,
						"type": "string"
					},
					"path": {
						"required": true,
						"type": "string"
					},
					"repo": {
						"required": true,
						"type": "string"
					}
				}
			}
		},
		"_smErrorCode": "GITHUB_WRITING_FILE"
	},
	"errorCode": "GITHUB_WRITING_FILE"
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant