Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PlayerCutクラスを作成して切り傷処理を移管した #1609

Merged
merged 16 commits into from
Sep 23, 2021

Conversation

Hourier
Copy link
Member

@Hourier Hourier commented Sep 22, 2021

#1498 の亜種であり後続作業です
mod_cut() は未実装です (差分が膨れ上がってしまうので後続作業とします)
証人クエのデスソードと戯れて正常動作を確認済です
ご確認下さい

@Hourier Hourier added the refactor 処理の整理、可読性の向上 label Sep 22, 2021
@Hourier Hourier added this to the 3.0.0Alpha40Release milestone Sep 22, 2021
@Hourier Hourier self-assigned this Sep 22, 2021
@Hourier Hourier added this to In Progress in C++移行 via automation Sep 22, 2021
int16_t tmp16s = player_ptr->effects()->stun()->current();
tmp16s = player_ptr->effects()->cut()->current();
rd_s16b(&tmp16s);
tmp16s = player_ptr->effects()->stun()->current();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stunの時に気づかなかったですが、stunの部分も合わせて処理がおかしいように思います。
これではなにも読めてないのではないかと。

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正し、起動不可コミットをrebaseしてforce pushしました
ご確認下さい

@Hourier Hourier linked an issue Sep 23, 2021 that may be closed by this pull request
Copy link
Member

@habu1010 habu1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一通り朦朧と切り傷の動作を試してみましたが大丈夫そうです。
Approveします。

@Hourier Hourier merged commit 3b5e5f7 into hengband:develop Sep 23, 2021
C++移行 automation moved this from In Progress to Done Sep 23, 2021
@Hourier Hourier deleted the Make-Player-Cut-Class branch September 23, 2021 08:04
@Hourier
Copy link
Member Author

Hourier commented Sep 23, 2021

長らく確認ありがとうございました!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor 処理の整理、可読性の向上
Development

Successfully merging this pull request may close these issues.

BadStatusSetterクラスのリファクタリング
2 participants