Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

朦朧効果のリニューアル準備 (TimedEffects/PlayerStunクラスの定義) #1498

Closed
Hourier opened this issue Sep 9, 2021 · 0 comments · Fixed by #1548
Closed

朦朧効果のリニューアル準備 (TimedEffects/PlayerStunクラスの定義) #1498

Hourier opened this issue Sep 9, 2021 · 0 comments · Fixed by #1548
Assignees
@Hourier
Labels
refactor 処理の整理、可読性の向上
Projects
変愚蛮怒3.0.0Beta到達プロジェクト C++移行
Milestone
3.0.0Alpha38Release

Comments

@Hourier
Copy link
Member

Hourier commented Sep 9, 2021

player_type::hoge の中にはTIME_EFFECT型 (実体はint16_t)が沢山ある
本題に入る前にこれを分離してplayer_typeを軽くしたい
但し全部移すと膨大な時間がかかるので今回はstunのみ
@Hourier Hourier added the refactor 処理の整理、可読性の向上 label Sep 9, 2021
@Hourier Hourier added this to the 3.0.0Alpha38Release milestone Sep 9, 2021
@Hourier Hourier self-assigned this Sep 9, 2021
@Hourier Hourier added this to To Do in C++移行 via automation Sep 9, 2021
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Created timed-effect/ for separating timed-e…
202115e 
…ffect variables from player_type
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined StunRank and get_rank()
0dfc098
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_chance()
e6151ef
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined set() and reset()
30e197b
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_stun_mes()
67177d5
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined is_stunned()
e0070e9
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced player_ptr->stun to PlayerStun::cur…
4a38c6e 
…rent() and so on
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct fail-rate calculation to dec…
6214790 
…rease_chance()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_damage() in PlayerStun
07d9c3e
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct damage-decrease calculation …
899656a 
…to decrease_damage()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct substitution to set()/reset()
4ddc801
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_expr() to divide View and Model
4e473b2
@Hourier Hourier mentioned this issue Sep 18, 2021
Merged
@Hourier Hourier linked a pull request Sep 18, 2021 that will close this issue
player_type から時限ステータスを分離した (朦朧のみ) #1548
Merged
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced player_ptr->stun to PlayerStun::cur…
7b3561d 
…rent() and so on
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct fail-rate calculation to dec…
7f8096b 
…rease_chance()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_damage() in PlayerStun
7088106
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct damage-decrease calculation …
4b4b185 
…to decrease_damage()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct substitution to set()/reset()
66ab910
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_expr() to divide View and Model
f5f9a8f
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Created timed-effect/ for separating timed-e…
c9eb381 
…ffect variables from player_type
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined StunRank and get_rank()
e49bae2
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_chance()
ee70bdc
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined set() and reset()
bf2ede1
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_stun_mes()
b1c366e
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined is_stunned()
010e6c9
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced player_ptr->stun to PlayerStun::cur…
b0826ad 
…rent() and so on
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct fail-rate calculation to dec…
b02c802 
…rease_chance()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_damage() in PlayerStun
14ab2ad
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct damage-decrease calculation …
c630f9e 
…to decrease_damage()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct substitution to set()/reset()
ce1444e
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_expr() to divide View and Model
f0a7340
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Habu氏から頂いたコメントを反映させた
9c13345
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Fix] hengband#1498 環境によっては朦朧が英語表記になってしまう事象を修正した / Resolved the issue…
de79b7d 
… that the expression of stun is English always in some environments
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Created timed-effect/ for separating timed-e…
6e00a9b 
…ffect variables from player_type
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined StunRank and get_rank()
123fa9b
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_chance()
711ed76
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined set() and reset()
cb409ab
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_stun_mes()
1ed2664
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined is_stunned()
44081f3
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced player_ptr->stun to PlayerStun::cur…
7278402 
…rent() and so on
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct fail-rate calculation to dec…
cd287e0 
…rease_chance()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined decrease_damage() in PlayerStun
9d06e97
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct damage-decrease calculation …
8709a37 
…to decrease_damage()
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Replaced direct substitution to set()/reset()
62dcbf2
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Defined get_expr() to divide View and Model
310826f
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Refactor] hengband#1498 Habu氏から頂いたコメントを反映させた
0cfe580
Hourier added a commit to Hourier/hengband that referenced this issue Sep 18, 2021
@Hourier
[Fix] hengband#1498 環境によっては朦朧が英語表記になってしまう事象を修正した / Resolved the issue…
130d537 
… that the expression of stun is English always in some environments
C++移行 automation moved this from To Do to Done Sep 18, 2021
@Hourier Hourier mentioned this issue Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hourier Hourier

Labels
refactor 処理の整理、可読性の向上
Projects
C++移行
Done
変愚蛮怒3.0.0Beta到達プロジェクト
Awaiting triage
Milestone
3.0.0Alpha38Release
Development

Successfully merging a pull request may close this issue.

player_type から時限ステータスを分離した (朦朧のみ) Hourier/hengband
1 participant
@Hourier