Skip to content

Commit

Permalink
Remove dependencies on 'meta' (#4647)
Browse files Browse the repository at this point in the history
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
  • Loading branch information
stuartmorgan committed Jan 10, 2022
1 parent 0088778 commit 94f645e
Show file tree
Hide file tree
Showing 10 changed files with 17 additions and 12 deletions.
4 changes: 4 additions & 0 deletions url_launcher/CHANGELOG.md
@@ -1,3 +1,7 @@
## 6.0.18

* Removes dependency on `meta`.

## 6.0.17

* Updates code for new analysis options.
Expand Down
1 change: 0 additions & 1 deletion url_launcher/lib/src/link.dart
Expand Up @@ -6,7 +6,6 @@ import 'dart:async';

import 'package:flutter/services.dart';
import 'package:flutter/widgets.dart';
import 'package:meta/meta.dart';
import 'package:url_launcher/url_launcher.dart';
import 'package:url_launcher_platform_interface/link.dart';
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';
Expand Down
3 changes: 1 addition & 2 deletions url_launcher/pubspec.yaml
Expand Up @@ -3,7 +3,7 @@ description: Flutter plugin for launching a URL. Supports
web, phone, SMS, and email schemes.
repository: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.17
version: 6.0.18

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -28,7 +28,6 @@ flutter:
dependencies:
flutter:
sdk: flutter
meta: ^1.3.0
url_launcher_android: ^6.0.13
url_launcher_ios: ^6.0.13
url_launcher_linux: ^2.0.0
Expand Down
3 changes: 2 additions & 1 deletion url_launcher_android/CHANGELOG.md
@@ -1,6 +1,7 @@
## NEXT
## 6.0.14

* Updates code for new analysis options.
* Removes dependency on `meta`.

## 6.0.13

Expand Down
3 changes: 1 addition & 2 deletions url_launcher_android/pubspec.yaml
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_android
description: Android implementation of the url_launcher plugin.
repository: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_android
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.13
version: 6.0.14

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -19,7 +19,6 @@ flutter:
dependencies:
flutter:
sdk: flutter
meta: ^1.3.0
url_launcher_platform_interface: ^2.0.3

dev_dependencies:
Expand Down
3 changes: 2 additions & 1 deletion url_launcher_ios/CHANGELOG.md
@@ -1,6 +1,7 @@
## NEXT
## 6.0.14

* Updates code for new analysis options.
* Removes dependency on `meta`.

## 6.0.13

Expand Down
3 changes: 1 addition & 2 deletions url_launcher_ios/pubspec.yaml
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_ios
description: iOS implementation of the url_launcher plugin.
repository: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_ios
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 6.0.13
version: 6.0.14

environment:
sdk: ">=2.14.0 <3.0.0"
Expand All @@ -18,7 +18,6 @@ flutter:
dependencies:
flutter:
sdk: flutter
meta: ^1.3.0
url_launcher_platform_interface: ^2.0.3

dev_dependencies:
Expand Down
4 changes: 4 additions & 0 deletions url_launcher_web/CHANGELOG.md
@@ -1,3 +1,7 @@
## 2.0.6

* Removes dependency on `meta`.

## 2.0.5

* Updates code for new analysis options.
Expand Down
2 changes: 1 addition & 1 deletion url_launcher_web/lib/url_launcher_web.dart
Expand Up @@ -5,8 +5,8 @@
import 'dart:async';
import 'dart:html' as html;

import 'package:flutter/foundation.dart' show visibleForTesting;
import 'package:flutter_web_plugins/flutter_web_plugins.dart';
import 'package:meta/meta.dart';
import 'package:url_launcher_platform_interface/link.dart';
import 'package:url_launcher_platform_interface/url_launcher_platform_interface.dart';

Expand Down
3 changes: 1 addition & 2 deletions url_launcher_web/pubspec.yaml
Expand Up @@ -2,7 +2,7 @@ name: url_launcher_web
description: Web platform implementation of url_launcher
repository: https://github.com/flutter/plugins/tree/master/packages/url_launcher/url_launcher_web
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+url_launcher%22
version: 2.0.5
version: 2.0.6

environment:
sdk: ">=2.12.0 <3.0.0"
Expand All @@ -21,7 +21,6 @@ dependencies:
sdk: flutter
flutter_web_plugins:
sdk: flutter
meta: ^1.3.0 # null safe
url_launcher_platform_interface: ^2.0.0

dev_dependencies:
Expand Down

0 comments on commit 94f645e

Please sign in to comment.