Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove meta dependencies from plugins where possible #95658

Closed
stuartmorgan opened this issue Dec 22, 2021 · 1 comment · Fixed by flutter/plugins#4647
Closed

Remove meta dependencies from plugins where possible #95658

stuartmorgan opened this issue Dec 22, 2021 · 1 comment · Fixed by flutter/plugins#4647
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.

Comments

@stuartmorgan
Copy link
Contributor

We're currently importing meta in a lot of plugins; we should instead use the fact that flutter/foundation.dart exports many common meta features, in order to reduce explicit dependencies (which increase the potential for version conflicts over time).
@stuartmorgan stuartmorgan added team Infra upgrades, team productivity, code health, technical debt. See also team: labels. plugin P2 Important issues not at the top of the work list labels Dec 22, 2021
@stuartmorgan stuartmorgan mentioned this issue Dec 22, 2021
Merged
11 tasks
@stuartmorgan stuartmorgan mentioned this issue Jan 6, 2022
Merged
11 tasks
stuartmorgan added a commit to godofredoc/plugins that referenced this issue Jan 10, 2022
@stuartmorgan
Remove dependencies on 'meta' (flutter#4647)
a0b7daa 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
proninyaroslav pushed a commit to proninyaroslav/plugins that referenced this issue Jan 10, 2022
@stuartmorgan @proninyaroslav
Remove dependencies on 'meta' (flutter#4647)
978b0bb 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
@Zazo032 Zazo032 mentioned this issue Jan 11, 2022
Merged
5 tasks
@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 24, 2022
henkibro pushed a commit to henkibro/url_launcher that referenced this issue Mar 1, 2022
@stuartmorgan
Remove dependencies on 'meta' (#4647)
94f645e 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
curt-weber pushed a commit to KWRI/google_maps_flutter that referenced this issue Nov 3, 2022
@stuartmorgan
Remove dependencies on 'meta' (#4647)
6b456b9 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
ValentinVignal pushed a commit to ValentinVignal/flutter__packages that referenced this issue Feb 23, 2023
@stuartmorgan
Remove dependencies on 'meta' (flutter#4647)
7278bea 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
zhouyuanbo pushed a commit to zhouyuanbo/video_player_2.6.1 that referenced this issue Jun 1, 2023
@stuartmorgan
Remove dependencies on 'meta' (#4647)
49d65ff 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
mkentos pushed a commit to CherryPeak-org/flutter-video-player that referenced this issue Mar 26, 2024
@stuartmorgan
Remove dependencies on 'meta' (#4647)
6a6e557 
Flutter re-exports everything from meta that we actually use, and all plugins by definition require Flutter, so there's no need to use `meta` instead of Flutter to access common annotations (e.g., immutable, visibleForTesting).

This removes all use of `meta`, as well as dependencies on the package, from all plugins.

Fixes flutter/flutter#95658
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Important issues not at the top of the work list package flutter/packages repository. See also p: labels. team Infra upgrades, team productivity, code health, technical debt. See also team: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependencies on 'meta' stuartmorgan/plugins
2 participants
@stuartmorgan @danagbemava-nc