This repository has been archived by the owner on Nov 27, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 14, 2014
+1 to plz fix this |
https://gist.github.com/trbs/3a0d2a1756c456d5d523 Fixes:
There is still one unit test failing:
|
Any progress on this? Just came across this library which we would love to use, but we're on Django 1.7... |
You can always install my django17 branch directly from github: This is what I use for Django17 |
Nice to know! |
Forgot that @henriquebastos committed it to git here as well... |
The branch I didn't had the time to investigate it any further. Any help is very welcome. If you're on a hurry you can:
|
…we need to to call change_aliases for our SqlAggregate conditional_template
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@trbs, @end0, @owais, @kawa-marcin,
I've applied the suggested patches to fix the call to
promote_joins
in Django 1.7.I've also updated travis and tox scripts to include Django's new version.
However due to Django's new AppConfig boot sequence, the tests are not running on Django 1.7.
I need to make all tests passing before releasing
0.5
. I plan to figure this out during the next week. Any help is very welcome.