Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported for 3.0.2 #8

Merged
merged 4 commits into from
Mar 13, 2018
Merged

Ported for 3.0.2 #8

merged 4 commits into from
Mar 13, 2018

Conversation

dalton5000
Copy link
Contributor

Changed what's needed for the plugin to work in Godot 3

@olsonjeffery
Copy link

olsonjeffery commented Mar 13, 2018

Nice! I have a 2.1 codebase that I'm on the cusp of porting to 3.0 .. I'll make an effort to integrate this into my own game ASAP.

As for the test of the demo project itself:

Everything looks good, except for input.. The enter button/break works fine, but it didn't collect the input/letters from me as I was typing. I went back and forth between @henriquelalves 's master and your godot3 branch and tested in 3.0.2 and 2.1 to verify. Tested on 3.0.2 64bit mono release running on macOS Sierra

That being said, this is a good first effort awesome and great, and I would be fine with this being merged as-is, and updating the README with a note that this feature will be restored when someone gets to it.

otherwise, 👍 👍 👍 👍 👍

@henriquelalves
Copy link
Owner

Nice, thank you @dalton5000! I'll merge it as soon as possible.

@olsonjeffery I just tested the pull-request on my local machine, and the Input was working for me as intended (at least as what I remember it should do). What exactly was happening when you tested? Were there no letters being printed on screen with the keyboard input? Did it printed correctly on the console Input Enter *input*?

@henriquelalves henriquelalves merged commit ea4c175 into henriquelalves:master Mar 13, 2018
@henriquelalves
Copy link
Owner

I'll update README accordingly. @olsonjeffery, if the problem persists, please create an issue so I can keep track on the new version.

The pull-request was merged, so I'll be closing here.

Repository owner locked as resolved and limited conversation to collaborators Mar 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants