Add docs on how to get Envoy stats with prometheus #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvaroaleman
force-pushed
the
feature/expose-envoy-stats
branch
from
7bb7d3f
to
9366c54
Compare
Bradamant3
reviewed
Mar 12, 2018
docs/prometheus.md
Outdated
| @@ -0,0 +1,47 @@ | |||
| # Prometheus | |||
|
|
|||
| With Contour it is possible to get metrics from Envoy. In order for this to work properly, | |||
There was a problem hiding this comment.
s/it is possible to/you can
s/In order for this to work properly,/To do so,
docs/prometheus.md
Outdated
| With Contour it is possible to get metrics from Envoy. In order for this to work properly, | ||
| you must expose the Envoy admin socket and configure the Prometheus service discovery correctly. | ||
|
|
||
| The admin socket can be made public by running |
There was a problem hiding this comment.
replace with:
"Make the admin socket public:"
(the command makes it clear; you don't need the extra words :-) )
docs/prometheus.md
Outdated
| sed 's#"bootstrap", "/config/contour.yaml"#"bootstrap", "/config/contour.yaml", "--admin-address", "0.0.0.0"#g' <your-contour-deployment>.yaml | ||
| ``` | ||
|
|
||
| Prometheus needs to have a configuration block that looks like this: |
Bradamant3
reviewed
Mar 12, 2018
alvaroaleman
force-pushed
the
feature/expose-envoy-stats
branch
from
c0ab5a8
to
9723e4b
Compare
Signed-off-by: Alvaro Aleman <alv2412@googlemail.com>
Signed-off-by: Alvaro Aleman <alv2412@googlemail.com>
alvaroaleman
force-pushed
the
feature/expose-envoy-stats
branch
from
9723e4b
to
08d234e
Compare
|
Thanks for your feedback @Bradamant3, I've updated the PR |
Bradamant3
approved these changes
Mar 12, 2018
|
Thanks. This should probably get a call out on the release notes which are landing straight after this. |
|
Yeah a mention in the release notes would probably be useful. For me the stats are the single real selling point of Contour, because its the one thing Nginx really lacks. |
|
If you want to add something to the release notes you can send me a PR to release-notes.md before Thursday.
… On 13 Mar 2018, at 10:24, Jennifer Rondeau ***@***.***> wrote:
@Bradamant3 approved this pull request.
Thanks for the changes!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
sunjayBhatia
pushed a commit
that referenced
this pull request
Jan 30, 2023
Signed-off-by: Daneyon Hansen <daneyonhansen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds docs on how to get envoy stats with Prometheus. It also adds Prometheus annotations for all deployments/daemonsets.
What's not ideal about this approach is that
I saw metrics are on the roadmap, what do you think about resolving the two above mentioned issues by proxying the Envoy stats with Contour?