Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

herbs new fails when git is not installed #110

Closed
willsoares opened this issue Apr 17, 2022 · 4 comments · Fixed by #120 or #138
Closed

herbs new fails when git is not installed #110

willsoares opened this issue Apr 17, 2022 · 4 comments · Fixed by #120 or #138
Assignees
@BritoDoug
Labels
bug Something isn't working released wip work in progress

Comments

@willsoares
Copy link

Describe the bug
While starting a new project with herbs new command, the process fails when trying to git init a repository, rather than informing the user that git isn't installed

To Reproduce

  1. Have a machine without git installed
  2. Run herbs new
  3. Select 'Do you want to initialize a Git repository? Yes'

image
@willsoares willsoares added the bug Something isn't working label Apr 17, 2022
@italojs
Copy link
Member

italojs commented May 4, 2022

I'm sure it's a bug because you really don't have the git installed into your machine, but I agree it's not a great development experience.
What do you think about checking if the git exists before we try to run the git? so, if the git isn't we could just show a message instead an error

@italojs
Copy link
Member

italojs commented May 4, 2022

if I help you, could you fix it for us, please?

Merged
@italojs italojs added the wip work in progress label May 12, 2022
@BritoDoug
Copy link
Contributor

I will take a look on that problem

BritoDoug pushed a commit to DevDougBrito/herbs-cli that referenced this issue Jun 25, 2022
@DevDougBrito
fix(git.js): broken when herbs new with git
1348133 
change the herbs new behavior when the user select to start with git whitout have git

fix herbsjs#110
@jhomarolo jhomarolo mentioned this issue Jun 25, 2022
Merged
3 tasks
github-actions bot pushed a commit that referenced this issue Jun 25, 2022
@semantic-release-bot
chore(release): 2.7.3 [skip ci]
3048f3d 
## [2.7.3](v2.7.2...v2.7.3) (2022-06-25)

### Bug Fixes

* adding command for herbs-CLI execution in the units tests ([bc73930](bc73930))
* check if git is installed in the operating system ([127b1c8](127b1c8)), closes [#110](#110)
* error message change if git command fails to execute ([9772757](9772757))
* **git.js:** broken when herbs new with git ([1348133](1348133)), closes [#110](#110)
@herbsjs-robot
Copy link

🎉 This issue has been resolved in version 2.7.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BritoDoug BritoDoug

Labels
bug Something isn't working released wip work in progress
Projects
Herbs - 3rd Anniversary Edition
Status: Done
Milestone
No milestone
4 participants
@willsoares @italojs @BritoDoug @herbsjs-robot