Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project break when author name is not standarized #135

Closed
jhomarolo opened this issue Jun 25, 2022 · 1 comment · Fixed by #137
Closed

Project break when author name is not standarized #135

jhomarolo opened this issue Jun 25, 2022 · 1 comment · Fixed by #137
Labels
bug Something isn't working released

Comments

@jhomarolo
Copy link
Contributor

Describe the bug
Using the author's name as "name\name" the cli breaks because the author's name is not in the right pattern

To Reproduce
Steps to reproduce the behavior:

  1. Run herbs new command
  2. Choose author name as name\name
  3. See error

Expected behavior
CLI should standardize the author name
@jhomarolo jhomarolo added the bug Something isn't working label Jun 25, 2022
crtotta pushed a commit to crtotta/herbs-cli that referenced this issue Jun 25, 2022
@CrizanTottaVx
fix(package json): replace author and project name
67d5e8c 
replace spaces and invalid characters

fix herbsjs#135
@crtotta crtotta mentioned this issue Jun 25, 2022
Merged
4 tasks
crtotta pushed a commit to crtotta/herbs-cli that referenced this issue Jun 25, 2022
@CrizanTottaVx
fix: fix regex
b64331f 
re herbsjs#135
github-actions bot pushed a commit that referenced this issue Jun 25, 2022
@semantic-release-bot
chore(release): 2.7.4 [skip ci]
a1a7143 
## [2.7.4](v2.7.3...v2.7.4) (2022-06-25)

### Bug Fixes

* fix regex ([b64331f](b64331f)), closes [#135](#135)
* **package json:** replace author and project name ([67d5e8c](67d5e8c)), closes [#135](#135)
@herbsjs-robot
Copy link

🎉 This issue has been resolved in version 2.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(package json): replace author and project name crtotta/herbs-cli
2 participants
@jhomarolo @herbsjs-robot