Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package json): replace author and project name #137

Merged
merged 4 commits into from
Jun 25, 2022

Conversation

crtotta
Copy link

@crtotta crtotta commented Jun 25, 2022

replace spaces and invalid characters

fix #135

Fixes #

Proposed Changes

1.fix(package json): replace author and project name #137

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

  • Label as breaking if this is a large fundamental change
  • Label as either automation, bug, documentation, enhancement, infrastructure, or performance

replace spaces and invalid characters

fix herbsjs#135
@jhomarolo jhomarolo added bug Something isn't working severity-minor Item is not urgent labels Jun 25, 2022
@codecov
Copy link

codecov bot commented Jun 25, 2022

Codecov Report

Merging #137 (bdd3db0) into main (23cdf86) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #137   +/-   ##
=======================================
  Coverage   81.42%   81.42%           
=======================================
  Files          23       23           
  Lines         393      393           
=======================================
  Hits          320      320           
  Misses         73       73           
Impacted Files Coverage Δ
src/generators/src/packagejson.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3048f3d...bdd3db0. Read the comment docs.

@dalssoft dalssoft merged commit 7ebdbf1 into herbsjs:main Jun 25, 2022
@herbsjs-robot
Copy link

🎉 This PR is included in version 2.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released severity-minor Item is not urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project break when author name is not standarized
5 participants