Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previously transparent frames are rendered with incorrect size when frame_bg_transparent=off #1576

Closed
Storchschnabel opened this issue Feb 26, 2024 · 1 comment · Fixed by #1577
Closed

Previously transparent frames are rendered with incorrect size when frame_bg_transparent=off #1576

Storchschnabel opened this issue Feb 26, 2024 · 1 comment · Fixed by #1577

Comments

@Storchschnabel
Copy link
Contributor

Storchschnabel commented Feb 26, 2024 •
edited

Steps to reproduce:

Xephyr :1 -screen 1920x1080 -resizeable &
export DISPLAY=:1
herbstluftwm &
herbstclient set frame_bg_transparent off 
herbstclient split right 0.5 
xclock &
sleep 1
herbstclient resize left +0.05
herbstclient focus right
killall xclock
herbstclient remove

Observed behaviour:

There is only one frame (herbstclient dump prints (clients max:0)), but it is only filled about half.

Expected behaviour:

The frame should be filled fully.
@Storchschnabel Storchschnabel mentioned this issue Feb 26, 2024
Merged
@t-wissmann
Copy link
Member

Thanks for the very precise description, I can reproduce the issue!
For the reproduction of this issue with the default autostart, I also had to set

hc set always_show_frame on

t-wissmann added a commit that referenced this issue Jun 7, 2024
@t-wissmann
Reproduce issue #1576 as a test case
0eda3d0 
This reproduces issue #1576 as a test case. The issue is that the frame
background masks were not correctly reset; the issue was reported and
fixed by @Storchschnabel.

Since the issue can be reproduced rather simply, this commit adds it as
a test case.
@t-wissmann t-wissmann mentioned this issue Jun 7, 2024
Merged
@mergify mergify bot closed this as completed in #1577 Jun 7, 2024
mergify bot pushed a commit that referenced this issue Jun 7, 2024
@Storchschnabel
Restore non-transparent frame by removing mask (#1577)
8a949c9 
This fixes incorrect rendering of resized, once-transparent focused frames with `frame_bg_transparent off`.

`window_make_intransparent` only took into account the _current_ size. Properly removing the mask allows for later resizing.
Fixes #1576.
mergify bot pushed a commit that referenced this issue Jun 8, 2024
@t-wissmann
Reproduce issue #1576 as a test case (#1584)
41f73d4 
This reproduces issue #1576 as a test case. The issue is that the frame background masks were not correctly reset; the issue was reported and fixed by @Storchschnabel.

Since the issue can be reproduced rather simply, this commit adds it as a test case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore non-transparent frame by removing mask Storchschnabel/herbstluftwm
2 participants
@t-wissmann @Storchschnabel