Add rule consequence floatplacement=smart #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new option 'smart' for the rule consequence floatplacement. It tries to place the floating window with as little overlap to other floating windows as possible. Beside documentation, this also adds test cases. Smart window placement is quite hard to test, so I have two test cases that actually verify the window positions, and one test case that only adds a bunch of clients without verifying anything (not contributing to code coverage).
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
======================================
Coverage 89.2% 89.3%
======================================
Files 102 102
Lines 8420 8494 +74
======================================
+ Hits 7519 7592 +73
- Misses 901 902 +1 |
blarz
changed the title
blarz
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new option 'smart' for the rule consequence floatplacement.
It tries to place the floating window with as little overlap to other
floating windows as possible. Beside documentation, this also adds
test cases.
Smart window placement is quite hard to test, so I have two test cases
that actually verify the window positions, and one test case that only
adds a bunch of clients without verifying anything (not contributing to
code coverage).
This has been requested in #73.