Add Ceph module #401
Closed
Add Ceph module #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good. Could you just add NaturalDocs documentation to the lens please? (see |
|
Good point! I'll add the documentation soon. Thanks! |
openstack-gerrit
pushed a commit
to openstack-archive/fuel-octane
that referenced
this pull request
Sep 8, 2016
- Graphs and puppet manifests part - Delete lib from .gitignore - Augeas lens for Ceph is copied and pasted, should be switched to the version from the upstream when [0] is merged and published. [0] hercules-team/augeas#401 Change-Id: I639cbf786971fea8c56b4da6b2661477b3b12c41
|
@PaulChe Could you add the documented lens to this PR? Thanks! |
|
@raphink any objections to merging this as-is ? I'd rather have this in without docs if it works |
|
Merged as 1a3b488 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple bunch of tests is added as well.