Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Systemd: fix parsing of envvars with spaces #659

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

ptoscano
Copy link
Contributor

@ptoscano ptoscano commented Feb 4, 2020

Allow spaces inside of values quoted with single or double quotes.

This amends commit f64d8bc that added support for quoted values.

TBH I'm not totally sure about it -- @raphink @domcleal can you please take a look whether it makes sense?

Allow spaces inside of values quoted with single or double quotes.

This amends commit f64d8bc that added
support for quoted values.
Copy link
Member

@raphink raphink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tests pass, so ok for me

@raphink raphink merged commit d438f52 into hercules-team:master Feb 4, 2020
@ptoscano ptoscano deleted the systemd-environment branch February 5, 2020 13:11
rwmjones pushed a commit to rwmjones/augeas that referenced this pull request Jan 12, 2022
Allow spaces inside of values quoted with single or double quotes.

This amends commit f64d8bc that added
support for quoted values.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants