Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generator: Add support for multiple output files #5

Closed
imagovrn opened this issue Jan 25, 2018 · 3 comments
Closed

Generator: Add support for multiple output files #5

imagovrn opened this issue Jan 25, 2018 · 3 comments

Comments

@imagovrn
Copy link
Contributor

Add support for multiple output files especially to python generator, to output proper package with respected namespaces. Adapt CMake for easier integration into C++

@VeaaC
Copy link
Collaborator

VeaaC commented Jan 26, 2018

One concern:
If the output filenames are not available at cmake configuration time, it would make things much harder.
So we should most likely make sure that the output filenames are deterministically inferable from the input file names (without running a parser, I would like to avoid that during config time).

@boxdot
Copy link
Collaborator

boxdot commented Nov 22, 2018

I prefer to have a single output file. The rationale is that the code is generated and therefore - not really meant for human editing. Splitting code in multiple files is usually done to enable people to work on different independent parts, i.e. it implies better maintainability. The latter is not important for generated code.

In case of python, they made an unfortunate decision to bind modules to the filesystem.

@imagovrn: If we are not going to work on this, what do you think about closing this issue?

gferon pushed a commit to gferon/flatdata that referenced this issue Feb 21, 2019
read_bytes! did not extend the sign bit for two's complement to the
whole bit size of the request unsigned type.

Also aligned the implementation with C++ version.
@VeaaC
Copy link
Collaborator

VeaaC commented Feb 24, 2019

We do not support including other files at the moment, so closing until this is needed

@VeaaC VeaaC closed this as completed Feb 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants