Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve flatdata-rs macro ecosystem #137

Merged
merged 12 commits into from
Apr 15, 2019
Merged

Improve flatdata-rs macro ecosystem #137

merged 12 commits into from
Apr 15, 2019

Conversation

VeaaC
Copy link
Collaborator

@VeaaC VeaaC commented Apr 13, 2019 •
edited
Loading

Fixes #136

VeaaC and others added 7 commits April 2, 2019 21:53
@VeaaC
Implement @range_with_next
71b0806 
Signed-off-by: Christian Vetter <veaac.fdirct@gmail.com>
@VeaaC
Add docs
572c2d3 
Signed-off-by: Christian Vetter <veaac.fdirct@gmail.com>
@VeaaC
Merge remote-tracking branch 'upstream/master' into range
df90291
@VeaaC
Merge Fixes
03e0ec8 
Signed-off-by: Christian Vetter <veaac.fdirct@gmail.com>
@VeaaC
Fix review comments
a9c7386 
Signed-off-by: Christian Vetter <veaac.fdirct@gmail.com>
@VeaaC
Change range_with_next to range
edf306f 
Signed-off-by: Christian Vetter <christian.vetter@here.com>
@VeaaC
Change benchmark as well
521dbb0 
Signed-off-by: Christian Vetter <christian.vetter@here.com>
@VeaaC VeaaC requested review from gferon and boxdot April 13, 2019 17:05
@VeaaC
Simplify/improve/manage visibiltiy of flatdata-rs macros
5898707 
Signed-off-by: Christian Vetter <christian.vetter@here.com>
@VeaaC
Merge remote-tracking branch 'upstream/master' into rust_macros
1359c41
@VeaaC
Fix merge
dd35d84 
Signed-off-by: Christian Vetter <christian.vetter@here.com>
boxdot
boxdot approved these changes Apr 15, 2019
View reviewed changes
flatdata-generator/flatdata/generator/templates/rust/archive.jinja2 Show resolved Hide resolved
flatdata-rs/lib/src/archive.rs Show resolved Hide resolved
flatdata-rs/lib/src/archive.rs Outdated Show resolved Hide resolved
flatdata-rs/lib/src/archive.rs Outdated Show resolved Hide resolved
flatdata-rs/lib/src/archive.rs Show resolved Hide resolved
@VeaaC
Fix review comments
d7b0d0c 
Signed-off-by: Christian Vetter <christian.vetter@here.com>
@VeaaC VeaaC merged commit 0683036 into heremaps:master Apr 15, 2019
@VeaaC VeaaC deleted the rust_macros branch April 15, 2019 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boxdot boxdot boxdot approved these changes

@gferon gferon Awaiting requested review from gferon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Simplify flatdata-rs macros
2 participants
@VeaaC @boxdot