Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add basic support for calling Dart functions from C++ in Dart generator #123

Closed
DanielKamkha opened this issue Jan 31, 2020 · 1 comment · Fixed by #141
Closed

Add basic support for calling Dart functions from C++ in Dart generator #123

DanielKamkha opened this issue Jan 31, 2020 · 1 comment · Fixed by #141
Assignees
@DanielKamkha
Labels
dart
Projects
Gluecodium
Milestone
Dart generator beta

Comments

@DanielKamkha
Copy link
Contributor

DanielKamkha commented Jan 31, 2020 •
edited

In-scope for this issue: calling Dart functions from C++ in a single-threaded scenario, with or without return values.

Out of scope: exception handling, multi-threading.
@DanielKamkha DanielKamkha added this to To do in Gluecodium via automation Jan 31, 2020
@DanielKamkha DanielKamkha mentioned this issue Jan 31, 2020
Closed
@DanielKamkha DanielKamkha self-assigned this Feb 11, 2020
@DanielKamkha DanielKamkha moved this from To do to In progress in Gluecodium Feb 11, 2020
@DanielKamkha
Copy link
Contributor Author

Useful info:
dart-lang/sdk#35761
dart-lang/sdk#37301
dart-lang/sdk#37022

DanielKamkha added a commit that referenced this issue Feb 12, 2020
@DanielKamkha
[draft] Dart listeners
859c5ff 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 12, 2020
@DanielKamkha
[draft] Dart listeners
7e2402c 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 12, 2020
@DanielKamkha
[draft] Dart listeners
2e18bfc 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 12, 2020
@DanielKamkha
[draft] Dart listeners
36127a2 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 12, 2020
@DanielKamkha
[draft] Dart listeners
596c242 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 13, 2020
@DanielKamkha
[draft] Dart listeners
942703c 
TODO: throwing listeners
TODO: listener return values

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 13, 2020
@DanielKamkha
[draft] Dart listeners
39f71d2 
TODO: throwing listeners
TODO: listener return values

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 13, 2020
@DanielKamkha
[draft] Dart listeners
2bf85cb 
TODO: throwing listeners

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
@DanielKamkha DanielKamkha changed the title Add support for calling Dart functions from C++ in Dart generator Add basic support for calling Dart functions from C++ in Dart generator Feb 14, 2020
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
[draft] Dart listeners
f19e322 
TODO: smoke tests

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
[draft] Dart listeners
1acebf1 
Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
Add "copy handle" logic to Dart bindings
f2b8848 
Updated Dart and FFI templates to avoid re-using the FFI handle stored
in Dart classes and instead pass it around as a copy. This enables
proper releasing of such handles, which will be required for "proxy"
infrastructure implementation for #123.

Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
[draft] Dart listeners
9ec3369 
Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
Add "copy handle" logic to Dart bindings
43dfa4b 
Updated Dart and FFI templates to avoid re-using the FFI handle stored
in Dart classes and instead pass it around as a copy. This enables
proper releasing of such handles, which will be required for "proxy"
infrastructure implementation for #123.

Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
[draft] Dart listeners
386ea19 
TODO: add smoke tests

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 14, 2020
@DanielKamkha
[draft] Dart listeners
e53c839 
TODO: add smoke tests

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
@DanielKamkha DanielKamkha mentioned this issue Feb 17, 2020
Merged
DanielKamkha added a commit that referenced this issue Feb 17, 2020
@DanielKamkha
Add "copy handle" logic to Dart bindings
55b41d3 
Updated Dart and FFI templates to avoid re-using the FFI handle stored
in Dart classes and instead pass it around as a copy. This enables
proper releasing of such handles, which will be required for "proxy"
infrastructure implementation for #123.

Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 17, 2020
@DanielKamkha
Add support for basic use cases of calling Dart code from C++
ce42201 
Updated Dart and FFI templates to generate "proxy" C++ classes
representing callable Dart interfaces in C++. This supports basic use
cases of calling Dart callbacks from C++ in the same thread, with or
without return value. Error handling and multithreading will be done
separately.

Added/updated smoke and functional tests as appropriate.

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 17, 2020
@DanielKamkha
Add "copy handle" logic to Dart bindings (#139)
879b9df 
Updated Dart and FFI templates to avoid re-using the FFI handle stored
in Dart classes and instead pass it around as a copy. This enables
proper releasing of such handles, which will be required for "proxy"
infrastructure implementation for #123.

Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
DanielKamkha added a commit that referenced this issue Feb 17, 2020
@DanielKamkha
Add support for basic use cases of calling Dart code from C++
8b8b2c6 
Updated Dart and FFI templates to generate "proxy" C++ classes
representing callable Dart interfaces in C++. This supports basic use
cases of calling Dart callbacks from C++ in the same thread, with or
without return value. Error handling and multithreading will be done
separately.

Added/updated smoke and functional tests as appropriate.

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
@DanielKamkha DanielKamkha mentioned this issue Feb 17, 2020
Merged
DanielKamkha added a commit that referenced this issue Feb 17, 2020
@DanielKamkha
Add support for basic use cases of calling Dart code from C++
285a6ea 
Updated Dart and FFI templates to generate "proxy" C++ classes
representing callable Dart interfaces in C++. This supports basic use
cases of calling Dart callbacks from C++ in the same thread, with or
without return value. Error handling and multithreading will be done
separately.

Added/updated smoke and functional tests as appropriate.

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
Gluecodium automation moved this from In progress to Done Feb 18, 2020
DanielKamkha added a commit that referenced this issue Feb 18, 2020
@DanielKamkha
Add support for basic use cases of calling Dart code from C++ (#141)
2d63972 
Updated Dart and FFI templates to generate "proxy" C++ classes
representing callable Dart interfaces in C++. This supports basic use
cases of calling Dart callbacks from C++ in the same thread, with or
without return value. Error handling and multithreading will be done
separately.

Added/updated smoke and functional tests as appropriate.

Resolves: #123
Signed-off-by: Daniel Kamkha <daniel.kamkha@here.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DanielKamkha DanielKamkha

Labels
dart
Projects
No open projects
Gluecodium
Done
Milestone
Dart generator beta
Development

Successfully merging a pull request may close this issue.

Add support for basic use cases of calling Dart code from C++ heremaps/gluecodium
1 participant
@DanielKamkha