HARP-11899: Cull only labels that are completely off screen

Signed-off-by: stefan.dachwitz <stefan.dachwitz@here.com>
heremaps · Oct 28, 2020 · 6e15d55 · 6e15d55
1 parent 45901ba
commit 6e15d55
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/@here/harp-mapview/lib/text/RenderState.ts b/@here/harp-mapview/lib/text/RenderState.ts
@@ -162,13 +162,17 @@ export class RenderState {
 
     /**
      * Updates the state to [[FadingState.FadingOut]].
-     * If previous state is [[FadingState.FadingOut]] or [[FadingState.FadedOut]] it remains
-     * unchanged.
+     * If previous state is [[FadingState.FadingOut]], [[FadingState.FadedOut]] or
+     * [[FadingState.Undefined]] it remains unchanged.
      *
      * @param time - Current time.
      */
     startFadeOut(time: number) {
-        if (this.m_state === FadingState.FadingOut || this.m_state === FadingState.FadedOut) {
+        if (
+            this.m_state === FadingState.FadingOut ||
+            this.m_state === FadingState.FadedOut ||
+            this.m_state === FadingState.Undefined
+        ) {
             return;
         }
 

diff --git a/@here/harp-mapview/test/RenderStateTest.ts b/@here/harp-mapview/test/RenderStateTest.ts
@@ -238,14 +238,15 @@ describe("RenderState", function() {
             const renderState = new RenderState();
             renderState.startFadeOut(100);
 
-            expect(renderState.isFadingOut()).to.be.true;
-            expect(renderState.startTime).to.equal(100);
+            expect(renderState.isFadingOut()).to.be.false;
+            expect(renderState.startTime).to.equal(0);
             expect(renderState.value).to.equal(0.0);
             expect(renderState.opacity).to.equal(1.0);
         });
 
         it("does not change an already fading out state", function() {
             const renderState = new RenderState();
+            renderState.startFadeIn(100, true);
             renderState.startFadeOut(100);
             renderState.startFadeOut(200);
 
@@ -377,6 +378,7 @@ describe("RenderState", function() {
 
         it("updates fading out states", function() {
             const renderState = new RenderState();
+            renderState.startFadeIn(100, false);
             renderState.startFadeOut(100);
             renderState.updateFading(200, false);
 
@@ -388,6 +390,7 @@ describe("RenderState", function() {
 
         it("switches to faded out after fading time passed", function() {
             const renderState = new RenderState();
+            renderState.startFadeIn(100, false);
             renderState.startFadeOut(100);
             renderState.updateFading(100 + DEFAULT_FADE_TIME, false);
 
@@ -399,6 +402,7 @@ describe("RenderState", function() {
 
         it("skips fading out when fading is disabled", function() {
             const renderState = new RenderState();
+            renderState.startFadeIn(100, false);
             renderState.startFadeOut(100);
             renderState.updateFading(200, true);