Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Commit

Permalink
HARP-7916: Add comment to explain when new label pass must be rendered.
Browse files Browse the repository at this point in the history
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
  • Loading branch information
atomicsulfate committed Dec 2, 2019
1 parent c86a113 commit 7d23554
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions @here/harp-mapview/lib/text/TextElementsRenderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -371,6 +371,13 @@ export class TextElementsRenderer {

this.reset();
this.prepopulateScreenWithBlockingElements(dataSourceTileList);

// New text elements must be placed either if text elements were updated in this frame
// or if any text element group was evicted. The second case happens when the group is not
// visited anymore and all it's elements just became invisible, which means there's newly
// available screen space where new text elements could be placed. A common scenario where
// this happens is zooming in/out: text groups from the old level may still be fading out
// after all groups in the new level were updated.
const placeNewTextElements = updateTextElements || anyTextGroupEvicted;
this.placeTextElements(time, placeNewTextElements);
this.placeOverlayTextElements();
Expand Down

0 comments on commit 7d23554

Please sign in to comment.