Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Commit

Permalink
Update Tween dependency
Browse files Browse the repository at this point in the history
Signed-off-by: Daniele Bacarella <daniele.bacarella@here.com>
  • Loading branch information
dbacarel committed Jan 13, 2021
1 parent 44b5a42 commit c254ae4
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
4 changes: 2 additions & 2 deletions @here/harp-map-controls/lib/MapAnimations.ts
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export abstract class CameraAnimation {
/**
* Tweening controller.
*/
protected tween?: TWEEN.Tween;
protected tween?: TWEEN.Tween<GeoCoordinates | Record<string, number>>;

/**
* `True` if animation is being played.
Expand Down Expand Up @@ -452,7 +452,7 @@ export class CameraPanAnimation extends CameraAnimation {
})
.onUpdate(({ latitude, longitude, altitude }) => {
this.mapView.geoCenter = new GeoCoordinates(latitude, longitude, altitude);
this.mapView.camera.position.z = altitude;
this.mapView.camera.position.z = altitude ?? 0;
});

this.tween.repeat(this.repeat);
Expand Down
3 changes: 1 addition & 2 deletions @here/harp-map-controls/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,7 @@
"@here/harp-geoutils": "^0.21.0",
"@here/harp-mapview": "^0.21.1",
"@here/harp-utils": "^0.21.0",
"@tweenjs/tween.js": "^17.4.0",
"@types/tween.js": "^17.2.0"
"@tweenjs/tween.js": "^18.6.4"
},
"devDependencies": {
"@types/chai": "^4.2.11",
Expand Down
13 changes: 4 additions & 9 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -1601,10 +1601,10 @@
"@turf/invariant" "^5.1.5"
d3-voronoi "1.1.2"

"@tweenjs/tween.js@^17.4.0":
version "17.4.0"
resolved "https://registry.yarnpkg.com/@tweenjs/tween.js/-/tween.js-17.4.0.tgz#2e9ab3f2111906b30dfe1ef3259a9781dd211d35"
integrity sha512-J3fzl1F6wvh8KXVVcIuHN12xi1ZDcPA/0Vix+ZcJYwZWVHUwfIqfvzYXXEw7ybeev6477KCTt9fKydU+ajUqcg==
"@tweenjs/tween.js@^18.6.4":
version "18.6.4"
resolved "https://registry.yarnpkg.com/@tweenjs/tween.js/-/tween.js-18.6.4.tgz#40a3d0a93647124872dec8e0fd1bd5926695b6ca"
integrity sha512-lB9lMjuqjtuJrx7/kOkqQBtllspPIN+96OvTCeJ2j5FEzinoAXTdAMFnDAQT1KVPRlnYfBrqxtqP66vDM40xxQ==

"@types/ajv@^1.0.0":
version "1.0.0"
Expand Down Expand Up @@ -1844,11 +1844,6 @@
resolved "https://registry.yarnpkg.com/@types/stats.js/-/stats.js-0.17.0.tgz#0ed81d48e03b590c24da85540c1d952077a9fe20"
integrity sha512-9w+a7bR8PeB0dCT/HBULU2fMqf6BAzvKbxFboYhmDtDkKPiyXYbjoe2auwsXlEFI7CFNMF1dCv3dFH5Poy9R1w==

"@types/tween.js@^17.2.0":
version "17.2.0"
resolved "https://registry.yarnpkg.com/@types/tween.js/-/tween.js-17.2.0.tgz#25f98311daecb165ab91ee2cd7f17a9b1e6cc30c"
integrity sha512-mOsqurEtFEzwgkVc/jDVE2XrjZBYTbrmDUyCr9GXmnfc6q5otokxFtKvSY/B21zgz9LVRIvRTawKczjKi57wrA==

"@types/ua-parser-js@^0.7.32":
version "0.7.33"
resolved "https://registry.yarnpkg.com/@types/ua-parser-js/-/ua-parser-js-0.7.33.tgz#4a92089511574e12928a7cb6b99a01831acd1dd7"
Expand Down

0 comments on commit c254ae4

Please sign in to comment.