Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

fail to update cubemap sky #1896

Closed
aoyaZY opened this issue Oct 13, 2020 · 5 comments
Closed

fail to update cubemap sky #1896

aoyaZY opened this issue Oct 13, 2020 · 5 comments

Comments

@aoyaZY
Copy link

aoyaZY commented Oct 13, 2020

Describe the bug
I tried to change my skyTexture by updating theme,but it was fail

I use ThemeLoader to load another theme.json, it works on most of styles but sky.
network shows that it has asked the new theme images,but it doesn't show on the map,the sky has no change

@aoyaZY
Copy link
Author

aoyaZY commented Oct 13, 2020

function updateSkyBackgroundColors() doesn't work

@nzjony
Copy link
Member

nzjony commented Oct 13, 2020

@aoyaZY , thanks for your issue. Do you have a working demo so that I can debug the problem?

@aoyaZY
Copy link
Author

aoyaZY commented Oct 13, 2020

@nzjony , thanks for your notice. But sorry, my demo is working base on my local data server , it may doesn't work in your environment. Maybe I can put some gif and images in here, you can see it.

I change theme like this
image
and it works like this
skybox

here is my tow different sky , they work well alone but update theme
image
image

nzjony added a commit that referenced this issue Oct 13, 2020
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@nzjony
Copy link
Member

nzjony commented Oct 13, 2020

@aoyaZY , thanks for the clarification, I have pushed a fix.

@aoyaZY
Copy link
Author

aoyaZY commented Oct 13, 2020

@nzjony , nice!

@nzjony nzjony closed this as completed in 69af4d1 Oct 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants