Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Allow CirclesTechnique points size to be specified in metres and pixels #2272

Closed
LukeParky opened this issue Aug 9, 2021 Discussed in #2256 · 1 comment
Closed

Allow CirclesTechnique points size to be specified in metres and pixels #2272

LukeParky opened this issue Aug 9, 2021 Discussed in #2256 · 1 comment
Labels
wontfix This will not be worked on

Comments

@LukeParky
Copy link
Contributor

LukeParky commented Aug 9, 2021

Discussed in #2256

In the source documentation it is stated that both SquaresTechnique and CirclesTechnique points are measured in pixels, but it is clear that SquaresTechnique is measured in metres. I would like the ability for CirclesTechniques to be measured in metres too.

I have linked a draft PR #2271 with some of my work to complete this but it is not in a ready state and I would appreciate help.

Original Discussion:

Originally posted by LukeParky August 3, 2021
Hi all, loving harp.gl but I've run into something that appears possibly inconsistent in the documentation and I'd like some advice.

Using SquaresTechnique for points, the size attribute represents size in the geo reference frame, whereas for CirclesTechnique the size attribute represents size in pixels.
In the source code PointTechniqueParams states size is in pixels so SquaresTechnique appears to be inconsistent.

I want to render a circle with the size in the geo reference frame, so having the behaviour of SquaresTechnique but rendering a circle instead of a square. Is there a way to do this using the established square or circle techniques or will I need to do some calculations to convert pixel size to geo size?

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 3, 2022
@stale stale bot closed this as completed Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant