Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Change circle technique size to metres #2271

Conversation

LukeParky
Copy link
Contributor

This is a draft pull request to solve the issues mentioned in discussion #2256

We aim to:

  • Allow CirclesTechnique points to be rendered with size measured in metres
  • Do the above in a way such that backwards compatibility is preserved

LukeParky and others added 2 commits August 9, 2021 11:57
Add MetricUnit config to `PointTechniqueParams` to switch between Meters and Pixels

Signed-off-by: Luke Parkinson <luke.parkinson@canterbury.ac.nz>
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@LukeParky
Copy link
Contributor Author

LukeParky commented Aug 9, 2021

This is a draft as I have not been able to successfully scale the CirclesTechnique sizes accurately or preserve the backwards compatibility. Please reach out to me if you can solve these issues.

@LukeParky
Copy link
Contributor Author

Hi, is there any room for help with this PR?

@nzjony
Copy link
Member

nzjony commented Sep 29, 2021

@LukeParky , sorry, I don't have any update. We created an internal ticket: HARP-16916, but as we have a lot of bugs / features to work on, this may take some time before we can help you on this sorry!

@stale
Copy link

stale bot commented Jan 3, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jan 3, 2022
@stale stale bot closed this Apr 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
HARP-16916 wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants