This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-7517: Partial support for rgba[..] and "rgba(..)" expressions in style. #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
robertoraggi
previously approved these changes
Nov 6, 2019
kkostecki
force-pushed
the
harp-7517-rgba-expression
branch
from
16f78f3
to
ebfd93e
Compare
robertoraggi
reviewed
Nov 6, 2019
… theme. Gives compatibility for themes using 4 channel colors in styling with attributes expressions like: - color: rgba[255, 255, 255, 0.5] - backgroundColor: "rgba(255, 255, 255, 0.5)" Although those styling attributes will be parsed and read, the alpha channel component will be silently ignored. Full support for alpha channel needs to be implemented. TODO: - support RGBA/ARGB colors internally in HARP engine, - alpha channel mapping to THREE.js opacity and transparent material properties, - four channels color interpolation, - additional unit tests covering different alpha value scenarios. Signed-off-by: Krystian Kostecki <ext-krystian.kostecki@here.com>
kkostecki
force-pushed
the
harp-7517-rgba-expression
branch
from
ebfd93e
to
a0d3701
Compare
Codecov Report
@@ Coverage Diff @@
## master #1010 +/- ##
==========================================
+ Coverage 45.12% 45.27% +0.14%
==========================================
Files 236 249 +13
Lines 22112 22351 +239
Branches 5025 5071 +46
==========================================
+ Hits 9978 10119 +141
- Misses 12134 12232 +98
Continue to review full report at Codecov.
|
zbigg
approved these changes
Nov 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives compatibility for themes using 4 channel colors in styling with
attributes expressions like:
Although those styling attributes will be parsed and read, the alpha
channel component will be silently ignored. Full support for alpha channel
need to be implemented.
TODO:
properties,
Signed-off-by: Krystian Kostecki ext-krystian.kostecki@here.com
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!