Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Fix WebTileDataSource API break due to removal of appId and appCode #1391

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

ninok
Copy link
Contributor

@ninok ninok commented Mar 17, 2020

No description provided.

@ninok ninok requested a review from musculman March 17, 2020 11:54
@ninok
Copy link
Contributor Author

ninok commented Mar 17, 2020

@harpgl-bot retest this please

@codecov-io
Copy link

Codecov Report

Merging #1391 into master will decrease coverage by 0.1%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
- Coverage   54.73%   54.62%   -0.11%     
==========================================
  Files         265      254      -11     
  Lines       23695    23423     -272     
  Branches     5310     5263      -47     
==========================================
- Hits        12969    12795     -174     
+ Misses      10726    10628      -98
Impacted Files Coverage Δ
...e/harp-webtile-datasource/lib/WebTileDataSource.ts 47.89% <75%> (+1.88%) ⬆️
...re/harp-text-canvas/lib/rendering/TextMaterials.ts 42.85% <0%> (-34.07%) ⬇️
@here/harp-mapview/lib/ThemeHelpers.ts 6.55% <0%> (-0.68%) ⬇️
@here/harp-omv-datasource/lib/clipPolygon.ts 96.96% <0%> (-0.47%) ⬇️
...rp-mapview/lib/text/TextElementsRendererOptions.ts 100% <0%> (ø) ⬆️
@here/harp-datasource-protocol/lib/Outliner.ts 100% <0%> (ø) ⬆️
...ere/harp-materials/lib/LuminosityHighPassShader.ts 100% <0%> (ø) ⬆️
@here/harp-test-utils/lib/WebGLStub.ts 100% <0%> (ø) ⬆️
...p-geoutils/lib/tiling/QuadTreeSubdivisionScheme.ts 100% <0%> (ø) ⬆️
@here/harp-utils/lib/Mixins.ts 76.92% <0%> (ø) ⬆️
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4303f3...297ca30. Read the comment docs.

@ninok ninok merged commit 9c922b3 into master Mar 17, 2020
@ninok ninok deleted the minor-appid-appcode branch March 17, 2020 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants