Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-10163: sunny coffee example #1515

Merged
merged 1 commit into from
May 19, 2020
Merged

HARP-10163: sunny coffee example #1515

merged 1 commit into from
May 19, 2020

Conversation

valerii-zinchenko
Copy link
Contributor

The use case of this example is to show shadows for a location at a certain time of the day, so that a user can search around for a sunny place.

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

16 similar comments
@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@valerii-zinchenko valerii-zinchenko changed the title HARP-10163: sunny coffee example WIP HARP-10163: sunny coffee example May 6, 2020
@ninok
Copy link
Contributor

ninok commented May 6, 2020

@harpgl-bot ok to test

@codecov-io
Copy link

codecov-io commented May 6, 2020 •
edited
Loading

Codecov Report

Merging #1515 into master will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
+ Coverage   60.01%   60.25%   +0.23%     
==========================================
  Files         262      275      +13     
  Lines       23859    24147     +288     
  Branches     5370     5422      +52     
==========================================
+ Hits        14320    14550     +230     
- Misses       9539     9597      +58
Impacted Files Coverage Δ
@here/harp-materials/lib/IconMaterial.ts 44.44% <0.00%> (-55.56%) ⬇️
@here/harp-map-controls/lib/Utils.ts 46.15% <0.00%> (-23.85%) ⬇️
@here/harp-omv-datasource/lib/OmvTiler.ts 50.00% <0.00%> (-16.67%) ⬇️
@here/harp-utils/lib/ObjectUtils.ts 83.33% <0.00%> (-10.22%) ⬇️
@here/harp-utils/lib/UrlUtils.ts 84.09% <0.00%> (-7.81%) ⬇️
@here/harp-datasource-protocol/lib/Extruder.ts 8.33% <0.00%> (-5.96%) ⬇️
@here/harp-lines/lib/TriangulateLines.ts 11.90% <0.00%> (-2.99%) ⬇️
@here/harp-mapview-decoder/lib/TileLoader.ts 75.35% <0.00%> (-2.67%) ⬇️
@here/harp-materials/lib/Utils.ts 81.42% <0.00%> (-1.91%) ⬇️
@here/harp-mapview/lib/ThemeHelpers.ts 6.89% <0.00%> (-1.17%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bea1c1c...b5b37de. Read the comment docs.

@valerii-zinchenko valerii-zinchenko changed the title WIP HARP-10163: sunny coffee example HARP-10163: sunny coffee example May 6, 2020
nzjony
nzjony previously approved these changes May 19, 2020
View reviewed changes
@here/harp-examples/src/real-time-shadows.ts Outdated
@@ -0,0 +1,324 @@
/*
* Copyright (C) 2020 HERE Europe B.V.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 2017-2020

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@valerii-zinchenko
HARP-10163: sunny coffee example
77b0398 
The usecase is to show shadows for a location at a certain time of the
day, so that a user can search around for a sunny place.

- @here/harp-examples/src/threejs_shadows.ts is replaced by
  real-time-shadows.ts example
- harp-mapview/lib/MapView.ts - fix shadow camera update after position
  updates of a directional light

Signed-off-by: Valerii Zinchenko <ext-valerii.zinchenko@here.com>
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2020 •
edited
Loading

Codecov Report

Merging #1515 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1515      +/-   ##
==========================================
- Coverage   60.61%   60.61%   -0.01%     
==========================================
  Files         278      278              
  Lines       24537    24539       +2     
  Branches     5524     5524              
==========================================
  Hits        14874    14874              
- Misses       9663     9665       +2
Impacted Files Coverage Δ
@here/harp-mapview/lib/MapView.ts 65.73% <0.00%> (-0.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b3dfe...77b0398. Read the comment docs.

@nzjony nzjony merged commit 66ebb17 into heremaps:master May 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nzjony nzjony nzjony approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@valerii-zinchenko @harpgl-bot @ninok @codecov-io @codecov-commenter @nzjony