Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Fix secondaryCategory type for solid line technique #1523

Merged
merged 1 commit into from
May 12, 2020

Conversation

ninok
Copy link
Contributor

@ninok ninok commented May 12, 2020

No description provided.

@ninok ninok requested a review from robertoraggi May 12, 2020 10:34
@codecov-io
Copy link

Codecov Report

Merging #1523 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1523      +/-   ##
==========================================
+ Coverage   60.25%   60.33%   +0.07%     
==========================================
  Files         264      277      +13     
  Lines       24084    24371     +287     
  Branches     5443     5497      +54     
==========================================
+ Hits        14513    14704     +191     
- Misses       9571     9667      +96     
Impacted Files Coverage Δ
...re/harp-datasource-protocol/lib/TechniqueParams.ts 59.52% <ø> (ø)
@here/harp-materials/lib/IconMaterial.ts 44.44% <0.00%> (-55.56%) ⬇️
@here/harp-map-controls/lib/Utils.ts 46.15% <0.00%> (-23.85%) ⬇️
@here/harp-omv-datasource/lib/OmvTiler.ts 50.00% <0.00%> (-16.67%) ⬇️
@here/harp-utils/lib/UrlUtils.ts 84.09% <0.00%> (-7.81%) ⬇️
@here/harp-datasource-protocol/lib/Extruder.ts 8.33% <0.00%> (-5.96%) ⬇️
@here/harp-lines/lib/TriangulateLines.ts 11.90% <0.00%> (-2.99%) ⬇️
@here/harp-materials/lib/Utils.ts 81.42% <0.00%> (-1.91%) ⬇️
@here/harp-mapview/lib/ThemeHelpers.ts 6.89% <0.00%> (-1.17%) ⬇️
@here/harp-utils/lib/Logger/ConsoleChannel.ts 69.23% <0.00%> (-0.77%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91624d6...609b6b4. Read the comment docs.

@ninok ninok merged commit 51f1cb5 into master May 12, 2020
@ninok ninok deleted the minor-fix-solid-line-typing branch May 12, 2020 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants