Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Add initial support for eslint. #1637

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Add initial support for eslint. #1637

merged 1 commit into from
Jun 24, 2020

Conversation

robertoraggi
Copy link
Member

@robertoraggi robertoraggi commented Jun 24, 2020

Add initial support for eslint.

This change adds an eslintrc configuration file with prettier
integration and common checks for typescript and standard js.
The npm script `eslint` can be used to check the files, e.g.

```
   $ yarn eslint
```

For now, the rules that the current codebase of harp.gl
is not following are disabled.

This change adds an eslintrc configuration file with prettier
integration and common checks for typescript and standard js.
The npm script `eslint` can be used to check the files, e.g.

```
   $ yarn eslint
```

For now, the rules that the current codebase of harp.gl
is not following are disabled.

Signed-off-by: Roberto Raggi <roberto.raggi@here.com>
@codecov
Copy link

codecov bot commented Jun 24, 2020

Codecov Report

Merging #1637 into master will increase coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1637      +/-   ##
==========================================
+ Coverage   62.33%   62.53%   +0.20%     
==========================================
  Files         274      274              
  Lines       24749    24749              
  Branches     5572     5572              
==========================================
+ Hits        15428    15478      +50     
+ Misses       9321     9271      -50     
Impacted Files Coverage Δ
...here/harp-mapview/lib/text/TextElementsRenderer.ts 69.56% <0.00%> (+1.08%) ⬆️
@here/harp-mapview/lib/MapView.ts 65.69% <0.00%> (+1.37%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a96e733...526d3fa. Read the comment docs.

@robertoraggi robertoraggi requested a review from ninok June 24, 2020 10:39
@robertoraggi robertoraggi merged commit a4f4eb1 into master Jun 24, 2020
@robertoraggi robertoraggi deleted the switch-to-eslint branch June 24, 2020 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants