Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Fix yarn test-browser #1665

Merged
merged 1 commit into from
Jul 7, 2020
Merged

MINOR: Fix yarn test-browser #1665

merged 1 commit into from
Jul 7, 2020

Conversation

nzjony
Copy link
Member

@nzjony nzjony commented Jul 7, 2020

Signed-off-by: Jonathan Stichbury 2533428+nzjony@users.noreply.github.com

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1665 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1665      +/-   ##
==========================================
- Coverage   62.90%   62.68%   -0.22%     
==========================================
  Files         277      277              
  Lines       25051    25051              
  Branches     5652     5652              
==========================================
- Hits        15758    15704      -54     
- Misses       9293     9347      +54     
Impacted Files Coverage Δ
@here/harp-mapview/lib/CameraMovementDetector.ts 61.97% <0.00%> (-28.17%) ⬇️
@here/harp-utils/lib/Logger/ConsoleChannel.ts 69.23% <0.00%> (-15.39%) ⬇️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 40.38% <0.00%> (-3.85%) ⬇️
@here/harp-mapview/lib/MapView.ts 64.65% <0.00%> (-1.32%) ⬇️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 68.47% <0.00%> (-1.09%) ⬇️
@here/harp-mapview/lib/Tile.ts 84.93% <0.00%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 702d21a...331e049. Read the comment docs.

@nzjony nzjony requested review from ninok and zbigg July 7, 2020 12:53
@nzjony nzjony merged commit e2a4e4e into master Jul 7, 2020
@nzjony nzjony deleted the jsminor7720 branch July 7, 2020 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants