This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-10772: Skip picking for invisible objects, depth prepass meshes … #1702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and background. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
HARP-10772_SkipInvisibleObjects
branch
from
f564f0a
to
cfffe62
Compare
Codecov Report
@@ Coverage Diff @@
## master #1702 +/- ##
==========================================
+ Coverage 63.08% 63.51% +0.42%
==========================================
Files 279 279
Lines 25246 25276 +30
Branches 5689 5700 +11
==========================================
+ Hits 15926 16053 +127
+ Misses 9320 9223 -97
Continue to review full report at Codecov.
|
nzjony
reviewed
Jul 21, 2020
| function createFakeObject<T extends THREE.Object3D>(type: new () => T): T { | ||
| const object = new type(); | ||
| sinon.stub(object, "raycast").callsFake((_, intersects) => { | ||
| intersects.push({ distance: 0, point: new THREE.Vector3(), object }); |
There was a problem hiding this comment.
LGTM, just please add a test case for the recursive code block
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
nzjony
approved these changes
Jul 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and background.
Signed-off-by: Andres Mandado andres.mandado-almajano@here.com
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!