This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MAPSJS-2709 Can toggle tile wrapping enabled #1759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1759 +/- ##
==========================================
- Coverage 64.58% 64.34% -0.25%
==========================================
Files 281 281
Lines 25512 25516 +4
Branches 5746 5747 +1
==========================================
- Hits 16478 16418 -60
- Misses 9034 9098 +64
Continue to review full report at Codecov.
|
robertoraggi
approved these changes
Aug 12, 2020
FraukeF
reviewed
Aug 12, 2020
| set tileWrappingEnabled(enabled: boolean) { | ||
| if (enabled !== this.m_tileWrappingEnabled) { | ||
| this.m_tileWrappingEnabled = enabled; | ||
| this.m_visibleTiles = this.createVisibleTileSet(); |
There was a problem hiding this comment.
You should check if the Projection is Planar before creating an new tile set, for the spherical projection the tileWrapping property should not change anything
There was a problem hiding this comment.
Opps, missed your comment, thanks, I will fix!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.