Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Replace deprecated lookAt API usage in the app generator #1804

Merged
merged 1 commit into from
Aug 28, 2020

Conversation

ninok
Copy link
Contributor

@ninok ninok commented Aug 28, 2020

No description provided.

@codecov
Copy link

codecov bot commented Aug 28, 2020

Codecov Report

Merging #1804 into master will increase coverage by 0.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   64.30%   64.50%   +0.19%     
==========================================
  Files         285      285              
  Lines       25526    25526              
  Branches     5728     5728              
==========================================
+ Hits        16415    16465      +50     
+ Misses       9111     9061      -50     
Impacted Files Coverage Δ
...here/harp-mapview/lib/text/TextElementsRenderer.ts 69.88% <0.00%> (+1.10%) ⬆️
@here/harp-mapview/lib/MapView.ts 67.88% <0.00%> (+1.26%) ⬆️
...ere/harp-mapview/lib/composing/LowResRenderPass.ts 44.23% <0.00%> (+3.84%) ⬆️
@here/harp-mapview/lib/CameraMovementDetector.ts 90.14% <0.00%> (+28.16%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb4b7d3...53b1149. Read the comment docs.

@ninok ninok merged commit 29858db into master Aug 28, 2020
@ninok ninok deleted the minor-generator-look-at branch August 28, 2020 09:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants