This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-11531: Look-at bounds for sphere. #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
3 times, most recently
from
f2bf35a
to
136feb4
Compare
Codecov Report
@@ Coverage Diff @@
## master #1830 +/- ##
==========================================
+ Coverage 64.67% 64.93% +0.26%
==========================================
Files 286 286
Lines 25782 25902 +120
Branches 5791 5818 +27
==========================================
+ Hits 16674 16820 +146
+ Misses 9108 9082 -26
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
2 times, most recently
from
42bdddc
to
cf776eb
Compare
FraukeF
reviewed
Sep 10, 2020
| ].forEach(ray => { | ||
| this.addFrustumIntersection(ray, frustum, coordinates); | ||
| }); | ||
| // There should only be one horizon intersection, if there's 2 take the last one. |
There was a problem hiding this comment.
in what condition would there be two intersections?
There was a problem hiding this comment.
I saw it happening even when theoretically it shouldn't. I assumed it was due to some precision problem when the starting side corner barely hits the world (whether the corner hits the world is decided doing raycasting, and horizon visibility is a completely separated computation in SphereHorizon). Let me revisit that to confirm.
There was a problem hiding this comment.
So i've confimed what I've said. I've just rewritten the comment to avoid confusion.
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
from
cf776eb
to
f210874
Compare
atomicsulfate
changed the base branch from
master
to
HARP-11531_SphereHorizon
atomicsulfate
force-pushed
the
HARP-11531_SphereHorizon
branch
from
eb1a53e
to
8e7525d
Compare
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
2 times, most recently
from
a058a1a
to
08a1975
Compare
atomicsulfate
force-pushed
the
HARP-11531_SphereHorizon
branch
from
8e7525d
to
3066977
Compare
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
from
a51e082
to
6544d01
Compare
FraukeF
reviewed
Sep 11, 2020
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
from
6544d01
to
e6999e4
Compare
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
from
930f5b4
to
fd76829
Compare
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
3 times, most recently
from
6846272
to
4168f40
Compare
|
@harpgl-bot retest this please |
FraukeF
previously approved these changes
Sep 21, 2020
|
@harpgl-bot retest this please |
Sphere projection is supported now. Also fix lint error in BoundsGeneratorTest.
Add support for multiple antimeridian crossings (concave poligons). Only supported for polygon with sides <=180 degrees longitude.
atomicsulfate
force-pushed
the
HARP-11531_Bounds4Sphere
branch
from
4168f40
to
c41783c
Compare
FraukeF
approved these changes
Sep 21, 2020
nzjony
pushed a commit
that referenced
this pull request
Sep 22, 2020
* HARP-11531: Look-at bounds for sphere. * HARP-11531: Move longitude span calculation to GeoCoordinates. * HARP-11531: Move coordinates wrapping to GeoPolygon. * HARP-11531: Adapt to SphereHorizon interface change in isFullyVisible. * HARP-11531: Adapt screen instructions in bounds generation example. Sphere projection is supported now. Also fix lint error in BoundsGeneratorTest. * HARP-11531: Fix GeoPolygon coordinate wrapping. Add support for multiple antimeridian crossings (concave poligons). Only supported for polygon with sides <=180 degrees longitude. * HARP-11531: Rewrite comment in addSideIntersectionsOnSphere.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!