Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-12599: Deprecates setTheme(theme, languages) #1953

Merged
merged 1 commit into from
Nov 6, 2020

Conversation

FraukeF
Copy link
Contributor

@FraukeF FraukeF commented Nov 5, 2020

Signed-off-by: Frauke Fritz frauke.fritz@here.com

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #1953 into master will decrease coverage by 0.08%.
The diff coverage is 93.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
- Coverage   65.36%   65.27%   -0.09%     
==========================================
  Files         293      293              
  Lines       26324    26335      +11     
  Branches     5942     5944       +2     
==========================================
- Hits        17207    17191      -16     
- Misses       9117     9144      +27     
Impacted Files Coverage Δ
.../harp-datasource-protocol/lib/StyleSetEvaluator.ts 89.05% <ø> (ø)
...-vectortile-datasource/lib/VectorTileDataSource.ts 68.96% <ø> (+0.07%) ⬆️
@here/harp-mapview-decoder/lib/TileDataSource.ts 77.21% <90.90%> (+1.50%) ⬆️
@here/harp-mapview/lib/DataSource.ts 89.70% <100.00%> (+0.23%) ⬆️
@here/harp-mapview/lib/PolarTileDataSource.ts 95.48% <100.00%> (ø)
@here/harp-mapview/lib/CameraMovementDetector.ts 81.69% <0.00%> (-11.27%) ⬇️
@here/harp-mapview/lib/VisibleTileSet.ts 78.10% <0.00%> (-1.59%) ⬇️
@here/harp-mapview/lib/MapView.ts 73.48% <0.00%> (-0.82%) ⬇️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 70.59% <0.00%> (-0.48%) ⬇️
@here/harp-mapview/lib/image/MapViewImageCache.ts 93.42% <0.00%> (+1.21%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e66365f...f4378c7. Read the comment docs.

robertoraggi
robertoraggi previously approved these changes Nov 6, 2020
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
@FraukeF FraukeF merged commit bd7a42d into master Nov 6, 2020
@FraukeF FraukeF deleted the deprecate-languages branch November 6, 2020 09:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants