Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Add dynamic markers example. #1997

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

atomicsulfate
Copy link
Collaborator

Public example to show how to render pickable markers (icon&text) from dynamically generated GeoJSON points using FeatureDataSource.

@codecov
Copy link

codecov bot commented Dec 1, 2020

Codecov Report

Merging #1997 (855f110) into master (7624c25) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1997   +/-   ##
=======================================
  Coverage   66.14%   66.14%           
=======================================
  Files         294      294           
  Lines       26299    26299           
  Branches     5909     5909           
=======================================
  Hits        17395    17395           
  Misses       8904     8904           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7624c25...855f110. Read the comment docs.

@atomicsulfate
Copy link
Collaborator Author

macbook tests please

Copy link
Contributor

@FraukeF FraukeF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I think it should move to the "Markers" section:

markers_dynamic.ts

or something similar

@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

FraukeF
FraukeF previously approved these changes Dec 3, 2020
@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

1 similar comment
@atomicsulfate
Copy link
Collaborator Author

@harpgl-bot retest this please

@atomicsulfate atomicsulfate merged commit f729dac into master Dec 4, 2020
@atomicsulfate atomicsulfate deleted the MINOR_DynamicMarkersExample branch December 4, 2020 09:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants