TextElementsRenderer supports Font and TextStyle updates #2008
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2008 +/- ##
==========================================
+ Coverage 66.22% 66.31% +0.08%
==========================================
Files 294 294
Lines 26299 26314 +15
Branches 5909 5929 +20
==========================================
+ Hits 17417 17449 +32
+ Misses 8882 8865 -17
Continue to review full report at Codecov.
|
FraukeF
force-pushed
the
textelementsrenderer-refactor
branch
3 times, most recently
from
17d2f8a
to
8ae740d
Compare
|
@harpgl_bot retest this please |
|
@harpgl-bot retest this please |
|
@harpgl-bot retest this please |
FraukeF
force-pushed
the
textelementsrenderer-refactor
branch
2 times, most recently
from
0300129
to
ec06a43
Compare
|
@harpgl-bot retest this please |
* FontCatalogLoader only loads FontCatalogs * MapView only ever has one instance of TextElementsRenderer * MapViewThemeManager awaits Theme updates on DataSources Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
…nderer Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
FraukeF
force-pushed
the
textelementsrenderer-refactor
branch
2 times, most recently
from
36a2133
to
95f47d2
Compare
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
FraukeF
force-pushed
the
textelementsrenderer-refactor
branch
from
95f47d2
to
fb398c8
Compare
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
FraukeF
force-pushed
the
textelementsrenderer-refactor
branch
from
313f1f5
to
ca3ebae
Compare
| } | ||
| this.m_textStyleCache.initializeTextElementStyles(this.m_textCanvases); |
There was a problem hiding this comment.
Is this needed both here and in updateTextStyles? Because MapView calls updateFontCatalogs and updateTextStyles immediately after.
There was a problem hiding this comment.
currently this is still needed, as in theory both methods can be called separately,..
But, I think in the next step in this process, which will make the TextStyleCache updatable instead of recreating a new one every time the theme is set, this will most probably disappear.
Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!