Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MINOR: Removes default font catalog option #2015

Merged
merged 2 commits into from
Dec 16, 2020
Merged

Conversation

FraukeF
Copy link
Contributor

@FraukeF FraukeF commented Dec 15, 2020

Signed-off-by: Frauke Fritz frauke.fritz@here.com

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
@codecov
Copy link

codecov bot commented Dec 15, 2020

Codecov Report

Merging #2015 (7dde5f9) into master (9c589d4) will decrease coverage by 0.05%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2015      +/-   ##
==========================================
- Coverage   66.31%   66.26%   -0.06%     
==========================================
  Files         294      294              
  Lines       26314    26313       -1     
  Branches     5929     5930       +1     
==========================================
- Hits        17449    17435      -14     
- Misses       8865     8878      +13     
Impacted Files Coverage Δ
...rp-mapview/lib/text/TextElementsRendererOptions.ts 100.00% <ø> (ø)
@here/harp-mapview/lib/text/TextStyleCache.ts 53.27% <69.23%> (-1.80%) ⬇️
...here/harp-mapview/lib/text/TextElementsRenderer.ts 71.97% <100.00%> (ø)
@here/harp-mapview/lib/text/FontCatalogLoader.ts 60.00% <0.00%> (-40.00%) ⬇️
@here/harp-utils/lib/Logger/ConsoleChannel.ts 23.07% <0.00%> (-30.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c589d4...7dde5f9. Read the comment docs.

… DEFAULT_FONT_CATALOG

Signed-off-by: Frauke Fritz <frauke.fritz@here.com>
@FraukeF FraukeF marked this pull request as ready for review December 16, 2020 09:17
@FraukeF FraukeF merged commit d7754a8 into master Dec 16, 2020
@FraukeF FraukeF deleted the remove-default-font branch December 16, 2020 09:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants