Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-13604 Upgrade three.js to r124 #2027

Merged
merged 1 commit into from
Jan 6, 2021
Merged

HARP-13604 Upgrade three.js to r124 #2027

merged 1 commit into from
Jan 6, 2021

Conversation

nzjony
Copy link
Member

@nzjony nzjony commented Jan 5, 2021

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

FraukeF
FraukeF previously approved these changes Jan 6, 2021
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Jan 6, 2021

Codecov Report

Merging #2027 (09cb0e7) into master (748ab58) will increase coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2027   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files         294      294           
  Lines       26313    26314    +1     
  Branches     5930     5930           
=======================================
+ Hits        17435    17436    +1     
  Misses       8878     8878           
Impacted Files Coverage Δ
@here/harp-mapview/lib/composing/MSAARenderPass.ts 36.11% <50.00%> (+0.89%) ⬆️
@here/harp-mapview/lib/MapView.ts 73.27% <100.00%> (ø)
@here/harp-test-utils/lib/WebGLStub.ts 100.00% <100.00%> (ø)
...rp-webtile-datasource/lib/HereWebTileDataSource.ts 54.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 748ab58...09cb0e7. Read the comment docs.

@nzjony nzjony merged commit 460405f into master Jan 6, 2021
@nzjony nzjony deleted the HARP-13604 branch January 6, 2021 12:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants