This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-13785: Fix multiple label fading issues. #2060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-13785_FixNonOptionalCityBullet
branch
2 times, most recently
from
f07659e
to
4d1c814
Compare
Unified styles don't set this parameter unless icon must be optional. textIsOptional is already false by default.
TextElementsRenderer expects fade times in ms.
If text is marked as invisible, it's icon is still rendered.
atomicsulfate
force-pushed
the
HARP-13785_FixNonOptionalCityBullet
branch
from
4d1c814
to
0236bf2
Compare
Codecov Report
@@ Coverage Diff @@
## master #2060 +/- ##
=======================================
Coverage 66.63% 66.63%
=======================================
Files 297 297
Lines 26336 26336
Branches 5951 5951
=======================================
Hits 17548 17548
Misses 8788 8788
Continue to review full report at Codecov.
|
|
@harpgl-bot retest this please |
FraukeF
approved these changes
Jan 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.