Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

Stopping use deprecated code. #2105

Merged
merged 1 commit into from
Feb 15, 2021
Merged

Stopping use deprecated code. #2105

merged 1 commit into from
Feb 15, 2021

Conversation

OleksiiZubko
Copy link
Contributor

@OleksiiZubko OleksiiZubko commented Feb 10, 2021

The classes OlpClientSettings and HRN in
@here/olp-sdk-dataservice-read will be removed
in the next release.

Those classes copied to the @here/olp-sdk-core.

This CR adapts the code according to future changes.

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

17 similar comments
@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@harpgl-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #2105 (a901e6e) into master (d6dcb53) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2105   +/-   ##
=======================================
  Coverage   67.66%   67.66%           
=======================================
  Files         297      297           
  Lines       26369    26370    +1     
  Branches     5957     5957           
=======================================
+ Hits        17843    17844    +1     
  Misses       8526     8526           
Impacted Files Coverage Δ
@here/harp-olp-utils/lib/OlpDataProvider.ts 65.78% <100.00%> (+0.92%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6dcb53...81222a7. Read the comment docs.

@FraukeF
Copy link
Contributor

FraukeF commented Feb 11, 2021

retest please

FraukeF
FraukeF previously approved these changes Feb 11, 2021
@FraukeF FraukeF enabled auto-merge (squash) February 12, 2021 07:58
@FraukeF
Copy link
Contributor

FraukeF commented Feb 12, 2021

retest please

@FraukeF
Copy link
Contributor

FraukeF commented Feb 12, 2021

ok to test

@FraukeF
Copy link
Contributor

FraukeF commented Feb 12, 2021

rebase please

@github-actions
Copy link

Rebase failed, please see logs for more info... Perhaps there is a conflict?

The classes `OlpClientSettings` and `HRN` in
`@here/olp-sdk-dataservice-read` will be removed
in the next release.

Those classes copied to the `@here/olp-sdk-core`.

This CR adapts the code according to future changes.

Signed-off-by: Oleksii Zubko <ext-oleksii.zubko@here.com>
@FraukeF
Copy link
Contributor

FraukeF commented Feb 15, 2021

rebuild please

@FraukeF FraukeF merged commit 898a27e into heremaps:master Feb 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants