This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MINOR: Fix error message on Datasource connection failure. #2124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2124 +/- ##
==========================================
- Coverage 67.68% 67.68% -0.01%
==========================================
Files 298 298
Lines 26384 26386 +2
Branches 5968 5971 +3
==========================================
+ Hits 17858 17859 +1
- Misses 8526 8527 +1
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
MINOR_FixDSConnectErrorMsg
branch
from
91febae
to
472be72
Compare
Caught error might be just a string from a rejected promise. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MINOR_FixDSConnectErrorMsg
branch
from
472be72
to
03f73c1
Compare
FraukeF
reviewed
Feb 26, 2021
| @@ -13,7 +13,10 @@ import { TileKey } from "@here/harp-geoutils"; | |||
| import { DataProvider } from "@here/harp-mapview-decoder"; | |||
| import { GeoJsonTiler } from "@here/harp-mapview-decoder/index-worker"; | |||
| import { silenceLoggingAroundFunction } from "@here/harp-test-utils"; | |||
| import { assert } from "chai"; | |||
| import * as chai from "chai"; | |||
There was a problem hiding this comment.
this looks interessting :) .. can you add a comment why its needed
There was a problem hiding this comment.
Comment added. chai-as-promised is a chai plugin to support assertions on promises, to install it you need to import chai, then the plugin, and finally do chai.use(chai_as_promised). We already use it in other test suites.
FraukeF
approved these changes
Feb 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caught error might be just a string from a rejected promise.