This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-14465: Fix world coordinates precision for screen space techniques #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
force-pushed
the
HARP-14465_FixMarkerPlacement
branch
3 times, most recently
from
62bc81c
to
f6d47e7
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
HARP-14465_FixMarkerPlacement
branch
from
f6d47e7
to
c8531df
Compare
POI and text positions, which use world coordinates (in contrast to tile coordinates used by meshes), were being decoded into a single precision buffer, hence losing precision. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
HARP-14465_FixMarkerPlacement
branch
from
c8531df
to
98354e4
Compare
Codecov Report
@@ Coverage Diff @@
## master #2152 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.01%
==========================================
Files 298 298
Lines 26376 26380 +4
Branches 5970 5970
==========================================
+ Hits 17858 17859 +1
- Misses 8518 8521 +3
Continue to review full report at Codecov.
|
germanz
approved these changes
Mar 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen space elements use world coordinates (other elements use local tile coordinates). Their coordinates were decoded into single precision buffers, and therefore placement was not accurate for high zoom levels.