This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
MINOR: Fix input handling in dynamic markers example. #2153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2153 +/- ##
==========================================
+ Coverage 67.67% 67.73% +0.05%
==========================================
Files 298 299 +1
Lines 26387 26470 +83
Branches 5973 5990 +17
==========================================
+ Hits 17857 17929 +72
- Misses 8530 8541 +11
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
MINOR_FixDynamicMarkersInput
branch
from
709377a
to
750a791
Compare
germanz
reviewed
Mar 24, 2021
germanz
reviewed
Mar 24, 2021
| handlePick(mapView, markersDataSource, event.pageX, event.pageY); | ||
| } | ||
| }); | ||
| let longTapTimer: number | undefined; |
There was a problem hiding this comment.
Shall we move out the long-press event related logic out of the example to make it reusable and not complicate the example logic?
There was a problem hiding this comment.
done. I've adapted the LongPressHandler class to support touch events.
Add touch screen support. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MINOR_FixDynamicMarkersInput
branch
3 times, most recently
from
234d895
to
38212d1
Compare
atomicsulfate
force-pushed
the
MINOR_FixDynamicMarkersInput
branch
from
38212d1
to
e1a0f8d
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MINOR_FixDynamicMarkersInput
branch
from
e1a0f8d
to
f322077
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
germanz
approved these changes
Mar 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add touch screen support.