Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

HARP-15480 Fix colors not being set correctly on custom materials #2196

Merged
merged 1 commit into from
May 25, 2021

Conversation

nzjony
Copy link
Member

@nzjony nzjony commented May 17, 2021

Thank you for contributing to harp.gl!

Before requesting a pull request, please remember to check the following documents:

If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.

CI Check

Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!

And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use git commit -s or append --signoff when you are committing to the repo.

Happy contributing!

Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
@nzjony nzjony closed this May 17, 2021
@nzjony nzjony reopened this May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #2196 (ec326c2) into master (2f10962) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2196   +/-   ##
=======================================
  Coverage   66.64%   66.65%           
=======================================
  Files         312      312           
  Lines       27748    27750    +2     
  Branches     6201     6201           
=======================================
+ Hits        18492    18496    +4     
+ Misses       9256     9254    -2     
Impacted Files Coverage Δ
@here/harp-mapview/lib/MapMaterialAdapter.ts 92.14% <100.00%> (+0.11%) ⬆️
@here/harp-materials/lib/EdgeMaterial.ts 63.04% <0.00%> (+2.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f10962...ec326c2. Read the comment docs.

@nzjony nzjony merged commit 67eaa32 into master May 25, 2021
@nzjony nzjony deleted the HARP-15480 branch May 25, 2021 08:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants