This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
HARP-14862: add tile coordinates to pick results #2220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2220 +/- ##
=======================================
Coverage 67.15% 67.16%
=======================================
Files 312 312
Lines 27679 27680 +1
Branches 6182 6183 +1
=======================================
+ Hits 18589 18591 +2
+ Misses 9090 9089 -1
Continue to review full report at Codecov.
|
ThFischer
reviewed
Jun 17, 2021
| const pickResult: PickResult = { | ||
| type: PickObjectType.Unspecified, | ||
| point: intersection.point, | ||
| distance: intersection.distance, | ||
| dataSourceName: intersection.object.userData?.dataSource, | ||
| intersection | ||
| intersection, | ||
| tilekey: tile?.tileKey |
There was a problem hiding this comment.
please name the property "tileKey"
nzjony
reviewed
Jun 17, 2021
dbacarel
force-pushed
the
harp-14862
branch
4 times, most recently
from
1a1aeb0
to
8507d02
Compare
|
rebase please |
Change-Id: Ie66a291dbad257fca2f61c74cd6f372e6e9f7dcc Signed-off-by: Daniele Bacarella <daniele.bacarella@here.com>
|
Rebase succeeded. |
github-actions
bot
force-pushed
the
harp-14862
branch
from
8507d02
to
2f78e55
Compare
nzjony
approved these changes
Jun 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniele Bacarella daniele.bacarella@here.com
Thank you for contributing to harp.gl!
Before requesting a pull request, please remember to check the following documents:
If you are adding new functionality we would highly appreciate if you can describe what is the capability you are adding and even better if you can add some examples. Please also remember to add tests for it.
CI Check
Our bots will check whether your PR can be directly integrated into the mainline. We have some internal integration tests running on the background, our bots will inform you of the next steps and someone from our team will take a look and help if needed!
And please do not forget to sign-off your commit! You can read more about DCO here. But, in short, you just need to use
git commit -sor append--signoffwhen you are committing to the repo.Happy contributing!