Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

ClipPlanesEvaluator cleanup #2244

Merged
merged 3 commits into from
Jul 30, 2021
Merged

Conversation

atomicsulfate
Copy link
Collaborator

@atomicsulfate atomicsulfate commented Jul 22, 2021

  • Extract some functions out of evaluator class into a private namespace.
  • Small documentation changes.
  • Minor code rearrangements.

No behaviour changes.

@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_ClipPlanesCleanup branch 2 times, most recently from a4a7b03 to 59f7c54 Compare July 23, 2021 10:30
@atomicsulfate atomicsulfate changed the title Accurate near distance for spherical projection. ClipPlanesEvaluator cleanup Jul 23, 2021
@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_ClipPlanesCleanup branch 2 times, most recently from 85d619a to 33f4ac9 Compare July 23, 2021 12:47
@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #2244 (f56af67) into master (6ce91d1) will increase coverage by 0.27%.
The diff coverage is 82.97%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2244      +/-   ##
==========================================
+ Coverage   67.40%   67.67%   +0.27%     
==========================================
  Files         312      312              
  Lines       27670    27660      -10     
  Branches     6182     6188       +6     
==========================================
+ Hits        18650    18718      +68     
+ Misses       9020     8942      -78     
Impacted Files Coverage Δ
@here/harp-mapview/lib/ClipPlanesEvaluator.ts 53.36% <82.97%> (-5.08%) ⬇️
@here/harp-mapview/lib/VisibleTileSet.ts 78.25% <0.00%> (-1.57%) ⬇️
@here/harp-mapview/lib/MapMaterialAdapter.ts 92.14% <0.00%> (-0.72%) ⬇️
@here/harp-mapview/lib/PickListener.ts 100.00% <0.00%> (ø)
@here/harp-mapview/lib/poi/PoiManager.ts 12.85% <0.00%> (ø)
@here/harp-vectortile-datasource/lib/OmvUtils.ts 90.56% <0.00%> (ø)
@here/harp-mapview/lib/text/TextElementBuilder.ts 100.00% <0.00%> (ø)
...here/harp-mapview/lib/text/TextElementsRenderer.ts 72.11% <0.00%> (ø)
...e/harp-mapview/lib/geometry/TileGeometryCreator.ts 72.68% <0.00%> (ø)
@here/harp-mapview/lib/text/TextElement.ts 93.75% <0.00%> (+0.07%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ce91d1...f56af67. Read the comment docs.

@atomicsulfate atomicsulfate force-pushed the MAPSJS-2660_ClipPlanesCleanup branch 2 times, most recently from 1539edd to 4405328 Compare July 23, 2021 14:02
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Also some other minor doc improvements.

Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
@atomicsulfate atomicsulfate merged commit c579784 into master Jul 30, 2021
@atomicsulfate atomicsulfate deleted the MAPSJS-2660_ClipPlanesCleanup branch July 30, 2021 14:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants