This repository has been archived by the owner on Mar 8, 2023. It is now read-only.
Accurate near distance for spherical projection. #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atomicsulfate
changed the base branch from
master
to
MAPSJS-2660_ClipPlanesCleanup
atomicsulfate
force-pushed
the
MAPSJS-2660_ClipPlanesCleanup
branch
5 times, most recently
from
4405328
to
468619d
Compare
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
4 times, most recently
from
d1c4127
to
ef367ba
Compare
atomicsulfate
commented
Jul 26, 2021
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
3 times, most recently
from
f9bae6b
to
1cd6e56
Compare
nzjony
reviewed
Jul 29, 2021
| ): number | undefined { | ||
| const fwdDir = camera.getWorldDirection(tmpVectors[0]); | ||
| const nearPlaneTanPoint = tmpVectors[1].copy(fwdDir).multiplyScalar(-R); | ||
| const camToTan = nearPlaneTanPoint.sub(camera.position); |
There was a problem hiding this comment.
I would rename camToTan to be at least camToTanPoint to make it a bit clearer.
There was a problem hiding this comment.
camToTanVec isn't quite accurate, because a vector is a relative displacement whereas a point is a fixed location. But I won't block this if you want to keep it.
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
from
1cd6e56
to
b3adf99
Compare
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
minGeometryHeight and maxGeometryHeight were undefined for fake elevation DataSource. Because of this, calculation of min/max geometry height at MapView.updateCameras() was returning NaN. Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
from
b3adf99
to
98d5448
Compare
Codecov Report
@@ Coverage Diff @@
## master #2245 +/- ##
==========================================
+ Coverage 67.70% 67.82% +0.12%
==========================================
Files 312 313 +1
Lines 27660 27690 +30
Branches 6188 6198 +10
==========================================
+ Hits 18726 18780 +54
+ Misses 8934 8910 -24
Continue to review full report at Codecov.
|
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
2 times, most recently
from
117daf9
to
5d10d76
Compare
|
@harpgl-bot retest this please |
Signed-off-by: Andres Mandado <andres.mandado-almajano@here.com>
atomicsulfate
force-pushed
the
MAPSJS-2660_FixNearPlaneSphere
branch
from
5d10d76
to
4d84b6c
Compare
nzjony
approved these changes
Aug 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.