Skip to content
This repository has been archived by the owner on Mar 8, 2023. It is now read-only.

MAPSJS-2983 Write to the console if we need too many attempts getting… #2284

Merged
merged 5 commits into from
Aug 23, 2021
Merged

MAPSJS-2983 Write to the console if we need too many attempts getting… #2284

merged 5 commits into from
Aug 23, 2021

Commits on Aug 23, 2021

  1. MAPSJS-2983 Write to the console if we need too many attempts getting… 

    … the image from the cache

Some failed attempts are ok, because there are cases where the DataSource is attached and ready
and the map has started to render, but the theme isn't fully set.

There are other ways to fix the problem, but they are generally more invasive and could introduce
regressions / performance issues, some options are:
- In the TileGeometryCreator::createAllGeometries method, await on the getTheme() Promise
- Don't allow new TextElements to be added while the theme is updating
- Investigate and remove all calls to update the mapview while the method `addDataSource` is called
  and see if this can be removed, because no update calls means we don't render and request new tiles
  which may contain references to POI's that don't yet exist on the cache.

For the sake of simplicity, this is the preferred method.

Change-Id: I441a0ff5f63fd3d2a403b43b422c3044c902c7a6
Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
    @nzjony
    nzjony committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    9f8c38e View commit details
    Browse the repository at this point in the history

  2. Update @here/harp-mapview/lib/poi/PoiRenderer.ts 

    Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
    @nzjony
    nzjony committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    02c4b0b View commit details
    Browse the repository at this point in the history

  3. MAPSJS-2983 Fix broken test 

    Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
    @nzjony
    nzjony committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    449318a View commit details
    Browse the repository at this point in the history

  4. MAPSJS-2983 Code review comments 

    Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
    @nzjony
    nzjony committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    5a44545 View commit details
    Browse the repository at this point in the history

  5. code review fixes: move initialization to beforeEach and use local re… 

    …source

Signed-off-by: Jonathan Stichbury <2533428+nzjony@users.noreply.github.com>
    @nzjony
    nzjony committed Aug 23, 2021
    Configuration menu
    Copy the full SHA
    715bad5 View commit details
    Browse the repository at this point in the history